cli send failing in 'Invalid params' RPCError

[cgzzz]

When trying to send using the counterpartyd cli, a following error occurs:

Traceback (most recent call last):
File "/home/me/counterpartyd_build/dist/counterpartyd/counterpartyd.py", line 432, in
args.unsigned)
File "/home/me/counterpartyd_build/dist/counterpartyd/counterpartyd.py", line 41, in cli
unsigned_tx_hex = util.api(method, params)
File "/home/me/counterpartyd_build/dist/counterpartyd/lib/util.py", line 50, in api
raise exceptions.RPCError('{}'.format(response_json['error']))
lib.exceptions.RPCError: {'message': 'Invalid params', 'code': -32602}

After a while of digging it appears that the problem is a missing bytes() cast for the txin['scriptPubKey']:

bitcoin.py/serialise():

# List of Inputs.
for i in range(len(inputs)):
    txin = inputs[i]
    s += binascii.unhexlify(bytes(txin['txid'], 'utf-8'))[::-1]         # TxOutHash
    s += txin['vout'].to_bytes(4, byteorder='little')   # TxOutIndex

    # FIXME bytes() cast missing here, should be like above?
    script = binascii.unhexlify(txin['scriptPubKey'])
    s += var_int(int(len(script)))                      # Script length
    s += script                                         # Script
    s += b'\xff' * 4                                    # Sequence

[adamkrellenstein]

I can't duplicate the error, and I don't know why, but your patch seems reasonable, so I added it anyway. Thanks. 8b36d25

[cgzzz]

PhantomPhreak, thanks for confirming the correctness of the fix and committing it. It now works for me, too.

[adamkrellenstein]

Thanks for submitting the issue!