FIX: Harden ZPF error, fix bug in failing equilibrium calls. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mapping v.Species could be dangerous since the components likely do not include SPECIES and only pure elements. We should use unpack_components It appears that we don't *need* it, almost out of luck, because all the current consumers of species use unpack_components internally in the important places, but this is updated no less.
This bug was introduced by c81a7d3, when it refactored the performance of calls to logpdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unpack_componentsin a few key places to make sure that changes in the pycalphad source that don't callunpack_componentswill continue to workin the future.