Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 21 update package json project name #27

Merged
merged 1 commit into from Oct 1, 2022

Conversation

yacinebenkaidali
Copy link
Collaborator

Which issues does this PR resolve?

resolves #21

How were things before and how does this PR change that? (If UI change add images)

update project name in the generated pakcage json

How should I review this PR? (Add implementation details, files to start with, etc.)

check the newly wrote code and the removed lines

Reviewer Checklist

  • Understood the purpose of the PR.
  • Tested it locally. Check for mobile compatibility if applicable.
  • Checked that we don't have any merge conflicts.
  • Went through the code line by line.

@yacinebenkaidali yacinebenkaidali self-assigned this Oct 1, 2022
@yacinebenkaidali yacinebenkaidali merged commit 3bdbe4d into develop Oct 1, 2022
@yacinebenkaidali yacinebenkaidali deleted the feature/21-generate-package-json branch October 1, 2022 12:32
yacinebenkaidali added a commit that referenced this pull request Oct 1, 2022
* Update project name in the generated pakcage json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate package.json instead of copying it.
1 participant