Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: allow customization of Firework effect damage #88

Closed
Tiagoquix opened this issue Dec 22, 2023 · 2 comments
Closed

Feature request: allow customization of Firework effect damage #88

Tiagoquix opened this issue Dec 22, 2023 · 2 comments
Labels
request :: setting Requesting a setting for existing perk
Milestone
2.5.0

Comments

@Tiagoquix
Copy link
Contributor

No description provided.

@Phil25
Copy link
Owner

Phil25 commented Dec 22, 2023

#72 overviews settings to be added to use legacy effects, including Firework.

I’ll change the suggested explode setting to damage and default to explode the player if damage would kill them. That be ok?

@Tiagoquix
Copy link
Contributor Author

Tiagoquix commented Dec 22, 2023 •
edited
Loading

Sure. It would be cool to the possibility of a value of -1 for damage so it would always kill the player regardless of buddha/godmode/current health points (basically the same as the legacy Smite idea).

@Phil25 Phil25 added this to the 2.5.0 milestone Dec 28, 2023
@Phil25 Phil25 added the request :: setting Requesting a setting for existing perk label Dec 28, 2023
@Phil25 Phil25 mentioned this issue Dec 28, 2023
Closed
10 tasks
@Phil25 Phil25 closed this as completed in a11d4d3 Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
request :: setting Requesting a setting for existing perk
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
2 participants
@Phil25 @Tiagoquix