avoidFirstLastClippingEnabled broken between versions

[Zarwan]

I'm trying to upgrade from 2.2.5 to the new release. My last label is getting cut off because the alignment has changed. I've tried using avoidFirstLastClippingEnabled but it didn't seem to do anything. I also tried adding offsets on either side but this moves the entire graph, not just the labels.

Before updating:

After updating:

[Zarwan]

Okay after some more research it seems that avoidFirstLastClippingEnabled was broken between versions. I went back to 2.2.5 and deleted avoidFirstLastClippingEnabled(true) and got the same result I'm getting on 3.0.0 with the call there.

However, note that only the last label has the incorrect alignment; the first one is fine. If I remove the call in 2.2.5 both labels have incorrect alignment.

I am calling setLabelCount(2, true) on my x-axis as well.

[Zarwan]

After debugging a bit, I think the problem is in XAxisRenderer.

for (int i = 0; i < positions.length; i += 2) {

    float x = positions[i];

    if (mViewPortHandler.isInBoundsX(x)) {

        String label = mXAxis.getValueFormatter().getFormattedValue(mXAxis.mEntries[i / 2], mXAxis);

        if (mXAxis.isAvoidFirstLastClippingEnabled()) {

            // avoid clipping of the last
            if (i == mXAxis.mEntryCount - 1 && mXAxis.mEntryCount > 1) {
                float width = Utils.calcTextWidth(mAxisLabelPaint, label);

                if (width > mViewPortHandler.offsetRight() * 2
                        && x + width > mViewPortHandler.getChartWidth())
                    x -= width / 2;

                // avoid clipping of the first
            } else if (i == 0) {

                float width = Utils.calcTextWidth(mAxisLabelPaint, label);
                x += width / 2;
            }
        }

        drawLabel(c, label, x, pos, anchor, labelRotationAngleDegrees);
    }
}

Since i is being incremented by 2, it will never equal mXAxis.mEntryCount - 1 unless the number of entries is odd, so the clipping logic won't be applied. @PhilJay

The problem isn't in 2.2.5 because I didn't need the call to setLabelCount, I just had a label for every value which was blank except for the first and last one.

[eapache]

Possibly 3928e28 ?

[eapache]

Still broken in 3.0.1.

[Zarwan]

I didn't look into this in detail, but maybe a fix for the same issue? @eapache #2719