You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary
The value passed to setScatterShapeSize on ScatterDataSet is not converted from dp to pixels in the shape renderers (e.g. CircleShapeRenderer) so the value is treated as a size in pixels, not dp. The scatter shape hole size, however, is correctly converted from dp to pixels. This is present in all the scatter shape renderers.
Expected Behavior
All sizes are in dp (as indicated in comments and documentation).
Possible Solution
Convert value from dp to pixels in the scatter shape renderers. e.g. change
final float shapeSize = dataSet.getScatterShapeSize();
to
final float shapeSize = Utils.convertDpToPixel(dataSet.getScatterShapeSize());
in all the renderers.
Device (please complete the following information):
Library Version 3.1.0
Additional Context
I will submit a PR for this
The text was updated successfully, but these errors were encountered:
Summary
The value passed to
setScatterShapeSize
on ScatterDataSet is not converted from dp to pixels in the shape renderers (e.g. CircleShapeRenderer) so the value is treated as a size in pixels, not dp. The scatter shape hole size, however, is correctly converted from dp to pixels. This is present in all the scatter shape renderers.Expected Behavior
All sizes are in dp (as indicated in comments and documentation).
Possible Solution
Convert value from dp to pixels in the scatter shape renderers. e.g. change
to
in all the renderers.
Device (please complete the following information):
Additional Context
I will submit a PR for this
The text was updated successfully, but these errors were encountered: