Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile fails with Vala 0.48 #7

Open
bserem opened this issue Jun 17, 2020 · 0 comments · May be fixed by #8
Open

Compile fails with Vala 0.48 #7

bserem opened this issue Jun 17, 2020 · 0 comments · May be fixed by #8

Comments

@bserem
Copy link

bserem commented Jun 17, 2020

Expected Behavior

While trying to run ninja the compilation fails because of Vala.

Current Behavior

../src/Model/JsonObject.vala:34.5-34.33: error: Creation method of abstract class cannot be public.
    public JsonObject.from_object (Json.Object object) {
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/Model/JsonObject.vala:339.5-339.26: error: Creation method of abstract class cannot be public.
    public JsonObjectArray (Json.Object object, string property_name) {
    ^^^^^^^^^^^^^^^^^^^^^^
../src/Services/RateLimiter.vala:91.5-91.22: error: Creation method of abstract class cannot be public.
    public QueuedEvent (string id) {
    ^^^^^^^^^^^^^^^^^^
Compilation failed: 3 error(s), 0 warning(s)

Possible Solution

Other projects had similiar experiences with Vala 0.42+ (akiraux/Akira@e21d4e1)

Steps to Reproduce (for bugs)

  1. Try to install with latest version of Vala (debian testing in my case)

Your Environment (for bugs)

  • Lights-Up Version: 480494a
  • OS Info:
$ uname -a && cat /etc/os-release
Linux dwarf 5.5.0-13.1-liquorix-amd64 #1 ZEN SMP PREEMPT liquorix 5.5-16.1~bullseye (2020-03-25) x86_64 GNU/Linux
PRETTY_NAME="Debian GNU/Linux bullseye/sid"
NAME="Debian GNU/Linux"
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
@maelstrom-firebrand maelstrom-firebrand linked a pull request Apr 23, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant