Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonet package broken, doesn't install #2222

Closed
tenzap opened this issue Feb 8, 2023 · 9 comments
Closed

Nonet package broken, doesn't install #2222

tenzap opened this issue Feb 8, 2023 · 9 comments

Comments

@tenzap
Copy link
Contributor

tenzap commented Feb 8, 2023

When trying to open the apk to install nonet it fails and doesn't install it.

v1.09e-r1

Same problem on android emulator:

image

@PhilippC
Copy link
Owner

PhilippC commented Feb 8, 2023

which apk are you referring to? The one from github releases or Github actions or Google Play?

@tenzap
Copy link
Contributor Author

tenzap commented Feb 8, 2023

The one from github releases

@IzzySoft
Copy link

IzzySoft commented Mar 1, 2023

@PhilippC you forgot to sign the nonet APK, my updater complains as well:

No signing certificates found in repo/keepass2android.keepass2android_nonet_189.apk

Also see here and #2233

@PhilippC
Copy link
Owner

PhilippC commented Mar 6, 2023

@PhilippC PhilippC closed this as completed Mar 6, 2023
@IzzySoft
Copy link

IzzySoft commented Mar 6, 2023

Confirmed thanks! Just wondering why the nonet flavor now includes "Google Services for Google Drive" (com.google.android.gms.drive)? No network permissions, though, so it mostly just looks confusing.

@tenzap
Copy link
Contributor Author

tenzap commented Mar 7, 2023

Thanks! Happy to see the new nonet version with many improvements (compared to the previous nonet version)

@PhilippC
Copy link
Owner

PhilippC commented Mar 7, 2023

Confirmed thanks! Just wondering why the nonet flavor now includes "Google Services for Google Drive" (com.google.android.gms.drive)? No network permissions, though, so it mostly just looks confusing.

KP2A is now built using make (for both variants), which required a couple of changes. This seems to be an unintended side effect of those. However, I haven't found the reason for it yet.

@IzzySoft
Copy link

IzzySoft commented Mar 7, 2023

Thanks for explaining, @PhilippC! Maybe there's a way to exclude that? It's obviously not used (at least not for what its name suggests – as how could it without network access), so removing shouldn't™ break things.

@PhilippC
Copy link
Owner

@IzzySoft I haven't found out yet where it comes from or why it's not removed when building nonet. BTW could you maybe update your release to https://github.com/PhilippC/keepass2android/releases/tag/1.09e-r5 which fixes the issue mentioned in #2292?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants