Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused fields in DomainLookupTree and Node. #1

Closed
Brian3647 opened this issue Oct 29, 2021 · 1 comment
Closed

Unused fields in DomainLookupTree and Node. #1

Brian3647 opened this issue Oct 29, 2021 · 1 comment

Comments

@Brian3647
Copy link

DomainLookupTree has a field named minimum_level and Node has a field named data.
None of this fields are used anywhere. And they are private fields.

What are they for?

@Phineas
Copy link
Owner

Phineas commented Oct 29, 2021

minimum_level is something I was going to implement later on which let you set a minimum domain level for lookups, so insertions would always be clustered and inserted by their minimum level which minimizes the traversal iterations if you always look up by at least a minimum level of domain. E.g. if minimum level was 1, then inserting www.google.com would insert google.com into the root of the tree, and so on. Will likely implement it soon.

data is stored in each node for visibility & debugging purposes, or if someone's directly using the traverse function and wants to identify the node they've hit.

@Phineas Phineas closed this as completed Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants