Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In optimally_align_text, we shouldn't consider a text's overlap with itself #46

Closed
colinmorris opened this issue Apr 17, 2018 · 2 comments

Comments

@colinmorris
Copy link
Contributor

In this line, when calculating the overlaps of text t using alignment a, we're including the size of the overlap with t itself, as originally placed.

One undesirable effect of this is that, if there are several alignments that don't overlap any points or fall outside the axes, we'll prefer the one that is most different from the original alignment, because it will have the least self-intersection. e.g. if the user originally chose to place their texts with ha=left, va=bottom, we'll prefer to change it to ha=right, va=top.

@Phlya
Copy link
Owner

Phlya commented Apr 17, 2018

Cool, I have noticed weird behavior which probably has to do with this issue, but haven't managed to figure out what was going on! As with other issues, this should be very easy to fix, would you like to do it yourself?

@Phlya
Copy link
Owner

Phlya commented May 27, 2018

I think this has been fixed.

@Phlya Phlya closed this as completed May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants