Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

External Frameworks Integration Notebook update #70

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

External Frameworks Integration Notebook update #70

wants to merge 1 commit into from

Conversation

mibaumgartner
Copy link
Member

Short Description

Update external frameworks integration notebooks

  • torchio
  • albumentations
  • imgaug
  • torchvision

PR Checklist

PR Implementer

This is a small checklist for the implementation details of this PR.
If you submit a PR, please look at these points (don't worry about the RisingTeam
and Reviewer workflows, the only purpose of those is to have a compact view of
the steps)

If there are any questions regarding code style or other conventions check out our
summary.

  • Implementation
  • Docstrings & Typing
  • Check __all__ sections and __init__
  • Unittests (look at the line coverage of your tests, the goal is 100%!)
  • Update notebooks & documentation if necessary
  • Pass all tests
  • Add the checksum of the last implementation commit to the Changelog

RisingTeam

RisingTeam workflow
  • Add pull request to project (optionally delete corresponding project note)
  • Assign correct label (if you don't have permission to do this, someone will do it for you.
    Please make sure to communicate the current status of the pr.)
  • Does this PR close an Issue? (add closes #IssueNumber at the bottom if
    not already in description)

Reviewer

Reviewer workflow
  • Do all tests pass? (Unittests, NotebookTests, Documentation)
  • Does the implementation follow rising design conventions?
  • Are the tests useful? (!!!) Are additional tests needed?
    Can you think of critical points which should be covered in an additional test?
  • Optional: Check coverage locally / Check tests locally if GPU is necessary to execute

@mibaumgartner mibaumgartner added the WIP Work in proress label May 3, 2020
@mibaumgartner mibaumgartner self-assigned this May 3, 2020
@codecov
Copy link

codecov bot commented May 3, 2020 •
edited

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files          32       32           
  Lines        1251     1251           
=======================================
  Hits         1224     1224           
  Misses         27       27
Flag Coverage Δ
#unittests 97.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22621f...9f90007. Read the comment docs.

@mibaumgartner mibaumgartner marked this pull request as draft May 3, 2020 22:20
@mibaumgartner mibaumgartner marked this pull request as ready for review May 3, 2020 22:21
@mibaumgartner mibaumgartner marked this pull request as draft May 3, 2020 22:21
@mibaumgartner mibaumgartner linked an issue May 3, 2020 that may be closed by this pull request
[FeatureRequest] Update External Libraries Notebook #64
Open
@mibaumgartner mibaumgartner added this to In progress in Docathlon May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mibaumgartner mibaumgartner

Labels
WIP Work in proress
Projects
Docathlon
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FeatureRequest] Update External Libraries Notebook
1 participant
@mibaumgartner