Support reordering sub flair #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steadyember
force-pushed
the
reorder-flair
branch
from
842604a
to
5356f80
Compare
Polsaker
requested changes
Jan 10, 2021
| """Write your migrations here.""" | ||
| migrator.add_fields( | ||
| migrator.orm['sub_flair'], | ||
| display_order=pw.IntegerField(constraints=[SQL("DEFAULT 1")]), |
There was a problem hiding this comment.
This shouild be like this:
Suggested change
| display_order=pw.IntegerField(constraints=[SQL("DEFAULT 1")]), | |
| display_order=pw.IntegerField(default=1), |
Otherwise migrations will fail with ValueError: display_order is not null but has no default
|
Four months have passed. I'm considering this PR as abandoned. Please create a new one if you still want your changes to get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #265