The service cannot be update properly in Honeypot services management.

[VertexC]

Version

PiPot 0.6

Encountered behaviour

After upload a serive under Honeypot services management, the service cannot be updated by upload the file again (by clicking update service code), and give error like "Could not parse the result" in the dialog window.

Additional information

127.0.0.1 - - [23/Mar/2019 01:59:35] "GET /services HTTP/1.1" 200 -
127.0.0.1 - - [23/Mar/2019 01:59:35] "GET /static/css/foundation.min.css HTTP/1.1" 200 -
127.0.0.1 - - [23/Mar/2019 01:59:35] "GET /static/css/app.css HTTP/1.1" 200 -
127.0.0.1 - - [23/Mar/2019 01:59:35] "GET /static/css/font-awesome.min.css HTTP/1.1" 200 -
127.0.0.1 - - [23/Mar/2019 01:59:35] "GET /static/img/favicon/favicon-32x32.png HTTP/1.1" 200 -
127.0.0.1 - - [23/Mar/2019 01:59:35] "GET /static/img/favicon/favicon-16x16.png HTTP/1.1" 200 -
127.0.0.1 - - [23/Mar/2019 01:59:35] "GET /static/img/favicon/favicon-96x96.png HTTP/1.1" 200 -
127.0.0.1 - - [23/Mar/2019 01:59:35] "GET /static/img/favicon/android-chrome-192x192.png HTTP/1.1" 200 -
/usr/src/pipot/server/mod_config/controllers.py:362: FlaskWTFDeprecationWarning: "flask_wtf.Form" has been renamed to "FlaskForm" and will be removed in 1.0.
form = UpdateServiceForm(prefix='serviceUpdate_')
[2019-03-23 01:59:40,450] ERROR in app: Exception on /services/update [POST]
Traceback (most recent call last):
File "/usr/src/pipot/pipot-env/local/lib/python2.7/site-packages/flask/app.py", line 2292, in wsgi_app
response = self.full_dispatch_request()
File "/usr/src/pipot/pipot-env/local/lib/python2.7/site-packages/flask/app.py", line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/src/pipot/pipot-env/local/lib/python2.7/site-packages/flask/app.py", line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/usr/src/pipot/pipot-env/local/lib/python2.7/site-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/src/pipot/pipot-env/local/lib/python2.7/site-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functionsrule.endpoint
File "/usr/src/pipot/server/mod_auth/controllers.py", line 48, in decorated_function
return f(*args, **kwargs)
File "/usr/src/pipot/server/mod_auth/controllers.py", line 71, in decorated_function
return f(*args, **kwargs)
File "/usr/src/pipot/server/mod_config/controllers.py", line 370, in services_ajax
file.save(temp_path)
File "/usr/src/pipot/pipot-env/local/lib/python2.7/site-packages/werkzeug/datastructures.py", line 2725, in save
dst = open(dst, 'wb')
IOError: [Errno 2] No such file or directory: u'./app/services/temp/TelnetService.py'
[Errno 2] No such file or directory: u'./app/services/temp/TelnetService.py'
Traceback (most recent call last):
File "/usr/src/pipot/pipot-env/local/lib/python2.7/site-packages/flask/app.py", line 2292, in wsgi_app
response = self.full_dispatch_request()
File "/usr/src/pipot/pipot-env/local/lib/python2.7/site-packages/flask/app.py", line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/src/pipot/pipot-env/local/lib/python2.7/site-packages/flask/app.py", line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/usr/src/pipot/pipot-env/local/lib/python2.7/site-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/src/pipot/pipot-env/local/lib/python2.7/site-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functionsrule.endpoint
File "/usr/src/pipot/server/mod_auth/controllers.py", line 48, in decorated_function
return f(*args, **kwargs)
File "/usr/src/pipot/server/mod_auth/controllers.py", line 71, in decorated_function
return f(*args, **kwargs)
File "/usr/src/pipot/server/mod_config/controllers.py", line 370, in services_ajax
file.save(temp_path)
File "/usr/src/pipot/pipot-env/local/lib/python2.7/site-packages/werkzeug/datastructures.py", line 2725, in save

Actual issues here

• The file directory is not set properly here. Should be "/pipot/service..." instead.
• The NotificationLoader is used instead of ServiceLoader. https://github.com/PiPot/pipot-server/blob/3adfbe1e4960fea35d1e1dc92a9f9a5f14a36e3c/mod_config/controllers.py#L373