Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow this to be actually used in Carthage. #13

Merged
merged 1 commit into from Nov 20, 2016
Merged

Allow this to be actually used in Carthage. #13

merged 1 commit into from Nov 20, 2016

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Nov 19, 2016

  • Do not integrate CocoaPods with the target PasswordTextField. This is unnecessary as the library itself has no dependencies.
  • Update the test dependencies Quick and Nimble to the latest published versions.

Without this commit, using PasswordTextField in Carthage will fail with the following message, because PODS_ROOT is not defined in Carthage.

*** Building scheme "PasswordTextField" in PasswordTextField.xcworkspace
** BUILD FAILED **


The following build commands failed:
	PhaseScriptExecution [CP]\ Check\ Pods\ Manifest.lock /Users/kennytm/Library/Developer/Xcode/DerivedData/PasswordTextField-bpvizxblfrzvlofkzgiyvwgfekxy/Build/Intermediates/PasswordTextField.build/Release-iphoneos/PasswordTextField.build/Script-66B4D3588EF01B594E66967A.sh
(1 failure)
error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.
A shell task (/usr/bin/xcrun xcodebuild -workspace /path/to/my/project/Carthage/Checkouts/PasswordTextField/PasswordTextField.xcworkspace -scheme PasswordTextField -configuration Release -sdk iphoneos ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build) failed with exit code 65:
** BUILD FAILED **


The following build commands failed:
	PhaseScriptExecution [CP]\ Check\ Pods\ Manifest.lock /Users/kennytm/Library/Developer/Xcode/DerivedData/PasswordTextField-bpvizxblfrzvlofkzgiyvwgfekxy/Build/Intermediates/PasswordTextField.build/Release-iphoneos/PasswordTextField.build/Script-66B4D3588EF01B594E66967A.sh
(1 failure)

* Do not integrate CocoaPods with the target `PasswordTextField`.
  This is unnecessary as the library itself has no dependencies.

* Update the test dependencies `Quick` and `Nimble` to the latest
  published versions.
@codecov-io
Copy link

codecov-io commented Nov 19, 2016

Current coverage is 80.98% (diff: 100%)

Merging #13 into master will not change coverage

@@             master        #13   diff @@
==========================================
  Files            10         10          
  Lines           263        263          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            213        213          
  Misses           50         50          
  Partials          0          0          

Powered by Codecov. Last update 8ad79d7...64d9646

@PiXeL16 PiXeL16 merged commit 7ee16d0 into PiXeL16:master Nov 20, 2016
@PiXeL16
Copy link
Owner

PiXeL16 commented Nov 20, 2016

Nice! Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants