Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Objective-C support #35

Merged
merged 1 commit into from Jun 30, 2017

Conversation

Gringox
Copy link

@Gringox Gringox commented Jun 26, 2017

Hello @PiXeL16, here is the PR for issue #33.

Please do test it before merging, I have not done a PR before and I do not want to break anything 馃槄.

Thank you again.

@Gringox
Copy link
Author

Gringox commented Jun 27, 2017

I ran the tests locally with:

xcodebuild -workspace RevealingSplashView.xcworkspace -scheme "RevealingSplashView" -destination "OS=10.3.1,name=iPhone 6s Plus" test GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=YES GCC_GENERATE_TEST_COVERAGE_FILES=YES | xcpretty -c

And I believe it did worked because I got the following output:

screen shot 2017-06-27 at 9 10 44 am

I do not know what went wrong.

@PiXeL16
Copy link
Owner

PiXeL16 commented Jun 30, 2017

Awesome thanks! 馃帀 Will fix CI in separate PR!

@PiXeL16 PiXeL16 closed this Jun 30, 2017
@PiXeL16 PiXeL16 reopened this Jun 30, 2017
@PiXeL16 PiXeL16 merged commit 949ae12 into PiXeL16:master Jun 30, 2017
@PiXeL16
Copy link
Owner

PiXeL16 commented Jun 30, 2017

BTW pushed version 0.4.0 with your fix https://cocoapods.org/pods/RevealingSplashView 馃憤

@Gringox
Copy link
Author

Gringox commented Jul 3, 2017

Nice! Thank you! 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants