parse_yaml.py: keep the trailing newline #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrunoB81HK Can you run pre-commit to format your change |
|
@pac48 I'm so used to it being installed on my repo that I forgot to install the hook before committing. This is done! |
|
@BrunoB81HK Looks good now. I will merge it if you can fix the merge conflict with main. |
|
@pac48 I think its done |
|
pre-commit is still failing with a formatting issue, do you mind running that and pushing the change? |
|
@tylerjw I don't mind. I will do it tomorrow. |
|
I'm sorry for the difficulty getting this merged. I just kicked off ci again and will merge when it passes. |
tylerjw
approved these changes
Dec 21, 2023
|
Great! Thanks a lot guys for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I have been using your library for a while and it's really great!
I have a very particular issue that is probably very niche, but I decided to try and fix it. As you can see in the pull request, the fix is very simple.
My use case is very particular, I use docker to prebuild my workspace and then I hop into the container to develop. When prebuilding with
--symlink-install, this package create the module inside mysrc/directory.The problem arise when I mount my workspace inside the container. It essentially wipe the generated modules. The solution I use is to rebuild the packages inside my container and then commit the generated modules.
Which comes to the main point of this pull request, the trailing new line. Since most linter and formatter enforce a newline at the end of a python file by default, the fact that the generated modules don't have one is a little bit annoying.
tl;dr: For the (few) packages that somehow commit the generated modules, adding a trailing newline to the generated module could be a nice quality of life upgrade.