Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate strings and arrays for size #24

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Conversation

tylerjw
Copy link
Contributor

@tylerjw tylerjw commented Jul 27, 2022

Signed-off-by: Tyler Weaver tyler@picknik.ai

@tylerjw tylerjw requested a review from pac48 July 27, 2022 18:57
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
@tylerjw tylerjw changed the title Validate string parameter is not empty Validate strings and arrays for size Jul 27, 2022
@pac48
Copy link
Collaborator

pac48 commented Jul 27, 2022

I am getting this error when I run the test

terminate called after throwing an instance of 'rclcpp::exceptions::InvalidParameterValueException'
  what():  Invalid value set during initialization for parameter 'gravity_compensation.CoG.pos': Invalid length '3' for parameter 'gravity_compensation.CoG.pos'. Required greater than: 3
[ros2run]: Aborted

Signed-off-by: Tyler Weaver <tyler@picknik.ai>
@tylerjw
Copy link
Contributor Author

tylerjw commented Jul 27, 2022

Thank you for running the test, I fixed the logic error.

I should turn running that node into an integration test.

@pac48 pac48 merged commit 633f091 into PickNikRobotics:main Jul 27, 2022
@tylerjw tylerjw deleted the not_empty branch July 28, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants