Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing export os depency causes downstream packages to fail #78

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

destogl
Copy link
Contributor

@destogl destogl commented Sep 29, 2022

Without this, I get the following error when building a package:

CMake Error at CMakeLists.txt:33 (add_library):
  Target "cool_position_controllers" links to target "tcb_span::tcb_span"
  but the target was not found.  Perhaps a find_package() call is missing for
  an IMPORTED target, or an ALIAS target is missing?


CMake Error at /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock.cmake:69 (add_executable):
  Target "test_position_controller_base" links to target "tcb_span::tcb_span"
  but the target was not found.  Perhaps a find_package() call is missing for
  an IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
  /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock.cmake:52 (_ament_add_gmock)
  CMakeLists.txt:93 (ament_add_gmock)

Important to mention that I am behind a controller that depends on parameter_traits and my controller is not (directly). Without this propagation of dependencies is bad.

@tylerjw tylerjw merged commit f8a6287 into PickNikRobotics:main Sep 29, 2022
@destogl destogl deleted the patch-1 branch September 29, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants