Allow none type #99
Merged
Allow none type #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destogl
reviewed
Mar 11, 2023
...parameter_library_py/generate_parameter_library_py/test/valid_parameters_with_none_type.yaml
Show resolved
Hide resolved
guihomework
force-pushed
the
allow-none-type
branch
from
cdbc68d
to
31441be
Compare
tylerjw
approved these changes
Mar 30, 2023
|
I read through this and am ready to merge this but it is still a Draft. If you believe this is ready can you make your PR not a draft? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one way of solving #97 following the idea of @destogl