Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PicknikTwistControler -> PicknikTwistController #10

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

abake48
Copy link
Contributor

@abake48 abake48 commented Jul 14, 2023

Correct the name of the twist controller

Copy link
Contributor

@MarqRazz MarqRazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #10 (96cecb9) into main (39234ed) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #10   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         56      56           
=====================================
  Misses        56      56           
Flag Coverage Δ
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@moriarty
Copy link
Contributor

Yep good catch. And obviously this is ABI breaking because the original name was a typo 🤦‍♂️ sorry

@moriarty moriarty merged commit bd89243 into main Jul 14, 2023
20 of 23 checks passed
@delete-merged-branch delete-merged-branch bot deleted the controler-to-controller branch July 14, 2023 18:52
@moriarty
Copy link
Contributor

This typo got released into Humble, but Iron and Rolling were being held for sync.

Rolling: ros/rosdistro#37912
Iron: ros/rosdistro#37914

@moriarty
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants