New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary recomputaion of `_pcm_energy(speech)` #6

Closed

csukuangfj opened this issue May 24, 2019 · 1 comment · Fixed by #7

Contributor

csukuangfj commented May 24, 2019

See the code
https://github.com/Picovoice/wakeword-benchmark/blob/1a6745de51577f646cfb46d061b85415d5216425/mixer.py#L36-L43

speech_energy is computed at
https://github.com/Picovoice/wakeword-benchmark/blob/1a6745de51577f646cfb46d061b85415d5216425/mixer.py#L39

Therefore, line
https://github.com/Picovoice/wakeword-benchmark/blob/1a6745de51577f646cfb46d061b85415d5216425/mixer.py#L43
can use speech_energy directly instead of computing it again.

The text was updated successfully, but these errors were encountered:

csukuangfj changed the title ~~unnecessary recomputtaion of _pcm_energy(speech)~~ unnecessary recomputaion of _pcm_energy(speech)

Member

kenarsa commented May 24, 2019

Cool! Can you please submit a PR and I will merge it in. Thanks.

csukuangfj mentioned this issue

Merged

kenarsa closed this as completed in #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment