Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing: UI Improvements #34

Closed
3 tasks done
andrejsharapov opened this issue Jan 29, 2023 · 4 comments
Closed
3 tasks done

Contributing: UI Improvements #34

andrejsharapov opened this issue Jan 29, 2023 · 4 comments
Labels
Bug Something isn't working as expected Question Further information is requested

Comments

@andrejsharapov
Copy link
Contributor

andrejsharapov commented Jan 29, 2023

Hello!

  • 1. I would like to help improve the site, but not in terms of functions, but in terms of interface and scss. I started by reducing the use of background-images on the site by replacing them with css pattern, but I can't test this as the command npm run dev throws an error:
info - Retrieving contributors from the API...
ReferenceError: fetch is not defined

Look at my changes: andrejsharapov@a43fea1

  • 2. I would advise you to use one of the commit message conventions like this.

  • 3. One more question. Do you have a site prototype in Figma that I can to duplicate and think about improving the site? This would be a good practice not only for me, but also for other users.

@mririgoyen
Copy link
Member

  1. You must be on Node 18. I'll make sure that gets added to the documentation.

  2. We'll take this into consideration, but for the most part do not see the overhead a benefit for us. We're not likely to ever provide a changelog or version the site.

  3. No, there is not. Things started as a XD file a long time ago, but everything else has been designed/developed in real-time.


Let me know if using Node 18 solves your issue.

@andrejsharapov
Copy link
Contributor Author

Yep.

info - Retrieving contributors from the API...
info - Writing 153 contributors to /public/data/contributors.json
(node:26224) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
INFO: Retrieving 7196 icons for Material Design Icons v7.1.96...   

But here I ran into another problem:

node:internal/process/esm_loader:97
     internalBinding('errors').triggerUncaughtException(
                               ^

[Error: ENOENT: no such file or directory, open 'D:\D:\...\pictogrammers.com\node_modules\@mdi\svg\svg\ab-testing.svg'] {
   errno: -4058,
   code: 'ENOENT',
   syscall: 'open',
   path: 'D:\\D:\\Development\\React\\pictogrammers.com\\node_modules\\@mdi\\svg\\svg\\ab-testing.svg'
}

Node.js v18.13.0

Somewhere knocking on the root.

path: 'D:\\D:\\

@mririgoyen
Copy link
Member

You're on Windows, so there's some cross platform issues happening here I will need to investigate.

@mririgoyen mririgoyen added Question Further information is requested Bug Something isn't working as expected labels Jan 29, 2023
@mririgoyen
Copy link
Member

You should be all set after pulling main. Fixed in 85a3d22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as expected Question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants