Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify compatibility with node.js ESM implementation #24

Open
3 tasks
Morgul opened this issue Mar 23, 2020 · 1 comment
Open
3 tasks

Verify compatibility with node.js ESM implementation #24

Morgul opened this issue Mar 23, 2020 · 1 comment

Comments

@Morgul
Copy link
Collaborator

Morgul commented Mar 23, 2020

Newer versions of node now support ESM module, however the workarounds we've been using for years are much more lax than this implementation. We need to make some changes to adjust.

  • Add "type": "module" to package.json
  • Convert all local imports to have the .js extention
  • Other issues as they come up

(Note: this is not an exhaustive list!)

@PieceMaker
Copy link
Owner

Thanks! We'll get on it in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants