Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-stale utACK shows as Stale utACK #76

Closed
ken2812221 opened this issue Sep 15, 2018 · 4 comments
Closed

Non-stale utACK shows as Stale utACK #76

ken2812221 opened this issue Sep 15, 2018 · 4 comments
Assignees
@PierreRochard
Labels
bug

Comments

@ken2812221
Copy link

In bitcoin/bitcoin#10973. I reviewed the latest commit e44e639558b1084f14a97847592616c3df9fff38 and typed it in the comment. It should show as utACK on bitcoinacks.com, however it shows stale ack.
@PierreRochard
Copy link
Owner

image

The heuristic I use is that bitcoinacks.com looks at the last commit in the PR, I was operating under the assumption that that's the one that always gets the automated Travis CI and reviewers ACK. Why isn't that the case with this PR?

@ken2812221
Copy link
Author

ken2812221 commented Sep 15, 2018 •
edited
Loading

Github sort commits by time order, not by commit order. You may should get head.sha to get real commit head in https://api.github.com/repos/bitcoin/bitcoin/pulls/10973.

@PierreRochard
Copy link
Owner

Ah that makes sense, thanks for explaining @ken2812221, I'll fix asap

@PierreRochard PierreRochard self-assigned this Sep 15, 2018
@PierreRochard PierreRochard mentioned this issue Sep 16, 2018
Merged
@PierreRochard
Copy link
Owner

Will deploy the fix later today

@jonatack jonatack mentioned this issue Jun 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PierreRochard PierreRochard

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PierreRochard @ken2812221