Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more instances of # noqa #17

Open
samuelallan72 opened this issue Aug 15, 2022 · 0 comments
Open

Remove more instances of # noqa #17

samuelallan72 opened this issue Aug 15, 2022 · 0 comments

Comments

@samuelallan72
Copy link

Most instances of noqa comments are on calling private methods externally on locally defined classes. This is a legit issue and can be easily fixed since this is code we control - if they truely are private methods, then we should work out why we're calling them externally, or if they're not really private, then we should rename them to clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant