Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clobberer concept #8

Open
samuelallan72 opened this issue Aug 15, 2022 · 0 comments · May be fixed by #18
Open

Update clobberer concept #8

samuelallan72 opened this issue Aug 15, 2022 · 0 comments · May be fixed by #18

Comments

@samuelallan72
Copy link

samuelallan72 commented Aug 15, 2022

"clobberer" naming is a little awkward here, suggesting that data is lost. No data is technically lost, since it's really summarising the statuses based on the output of a function.

The clobber classes are very verbose, when the real use is a single pure function with a certain signature. No need to add object orient programming when functions are plenty and just as clear.

Propose the following:

  • rename clobberer terminology to "summarizer"
  • use functions instead of classes for the clobberers/summarizers.
@PietroPasotti PietroPasotti linked a pull request Aug 18, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant