Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace clash with built-in farming mod in 0.4.16 #28

Open
mikyra opened this issue Sep 6, 2018 · 1 comment
Open

namespace clash with built-in farming mod in 0.4.16 #28

mikyra opened this issue Sep 6, 2018 · 1 comment

Comments

@mikyra
Copy link

mikyra commented Sep 6, 2018

Unfortunately the mod doesn't follow conventions placing its data and functions not in a table corresponding to the module name (aka farming_plus), but in the table farming.

Leading to a clash with the built-in farming mod shipped with 4.016.

Well, to be percise there is even two clashes.
One with the field farming.registered_plants that gets happily reset to {} by the farming_plus mod.
Not a big deal as the built-in farming mod never makes use of it.

Worse is the clash with the function farming.place_seed() as this one is really needed by the built-in farming mod, but happily gets overwritten by the version shipped with farming_plus.
As an effect neither wheat nor cotton will grow if farming_plus is used.

IMHO data and functions of the mod should really, really live in the namespace (aka table) farming_plus to A) fix the current issue B) prevent future problems like this one.

To verify the named function really is the culprit I ran a quick 'sed -i s/place_seed/FIXME_place_seed/g' over the lua files of the mod.
Wheat is growing again after that operation.

@HybridDog
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants