Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Menu API rework #9

Open
3 tasks
PinewoodPip opened this issue May 20, 2023 · 0 comments
Open
3 tasks

Context Menu API rework #9

PinewoodPip opened this issue May 20, 2023 · 0 comments
Assignees
Labels
library Issues relating to core libraries rework Feature or library reworks/rewrites. UI Issues relating to UIs (both Larian's and custom ones)

Comments

@PinewoodPip
Copy link
Owner

The context menu API is incredibly old at this point (2 years, almost) and needs modernizing to adhere to current standards. All current functionality should be kept.

  • Annotate all methods and structures
  • Change structures to use current naming conventions for fields (currently they are all in lowercase which is cringe)
  • Change the way menus are declared and hooked, as current solution is a bit clunky. Allow the user to pass a default context menu with any call to open it. Then have a hook to modify the menu.

The UI currently replaces the vanilla one. Ideally it should be turned into a Generic UI, however the hardcoded quirks of the vanilla context menu could make it difficult to use an overlay. The change to Generic can be made later (it wouldn't affect the API).

@PinewoodPip PinewoodPip added rework Feature or library reworks/rewrites. library Issues relating to core libraries UI Issues relating to UIs (both Larian's and custom ones) labels May 20, 2023
@PinewoodPip PinewoodPip self-assigned this May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library Issues relating to core libraries rework Feature or library reworks/rewrites. UI Issues relating to UIs (both Larian's and custom ones)
Projects
None yet
Development

No branches or pull requests

1 participant