Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Refactor OneDesk components to use latest version of API #12276

Closed
malexanderlim opened this issue Jun 5, 2024 · 4 comments · Fixed by #12429
Closed

[FEATURE] Refactor OneDesk components to use latest version of API #12276

malexanderlim opened this issue Jun 5, 2024 · 4 comments · Fixed by #12429
Assignees
Labels
enhancement New feature or request triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@malexanderlim
Copy link
Contributor

malexanderlim commented Jun 5, 2024

Is your feature request related to a problem? Please describe.
OneDesk has a new version of their API, which utilizes API Keys instead of basic auth.
This request is to refactor all of our component to the latest version of the API, to support the new API Key based auth.

API Documentation: https://www.onedesk.com/dev/

@malexanderlim malexanderlim added the enhancement New feature or request label Jun 5, 2024
@malexanderlim malexanderlim added this to To Do in Component (Source and Action) Backlog via automation Jun 5, 2024
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Jun 5, 2024
@malexanderlim malexanderlim moved this from To Do to Prioritized in Component (Source and Action) Backlog Jun 5, 2024
@jcortes jcortes self-assigned this Jun 10, 2024
@jcortes jcortes moved this from Prioritized to Doing in Component (Source and Action) Backlog Jun 10, 2024
@jcortes jcortes moved this from Doing to Ready for PR review in Component (Source and Action) Backlog Jun 13, 2024
@jcortes
Copy link
Collaborator

jcortes commented Jun 13, 2024

To QA and Dev: I had to remove the source onedesk-new-timesheet-created because there is no equivalence in the latest API so we can ignore that component at the moment

Update

The following activity types were throwing the error {"timestamp":"2024-06-14T15:46:04.324+00:00","status":500,"error":"Internal Server Error","path":"/rest/public/activities/filter/details"} so I removed them for now

  • added a Internal message -> onedesk-new-public-message-created
  • project updated -> onedesk-new-project-updated

I didn't find a straight equivalence with onedesk-new-item-updated activity so I removed it.

About onedesk-new-timesheet-created the equivalent activity type is actual work updated according to OneDesk Team Support

@michelle0927 michelle0927 moved this from Ready for PR review to Changes Required in Component (Source and Action) Backlog Jun 14, 2024
@jcortes jcortes moved this from Changes Required to Ready for PR review in Component (Source and Action) Backlog Jun 14, 2024
@michelle0927 michelle0927 moved this from Ready for PR review to Ready for QA in Component (Source and Action) Backlog Jun 14, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Jun 17, 2024
@vunguyenhung vunguyenhung moved this from In QA to Ready for QA in Component (Source and Action) Backlog Jun 17, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Jun 17, 2024
@vunguyenhung vunguyenhung moved this from In QA to Changes Required in Component (Source and Action) Backlog Jun 17, 2024
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/FEATURE-Refactor-OneDesk-components-to-use-latest-version-of-API-d03aed9af96e4f6191eae4eebf6b4c7f

@jcortes jcortes moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Jun 17, 2024
@jcortes
Copy link
Collaborator

jcortes commented Jun 17, 2024

HI @vunguyenhung I had to change the name of the activiy from actual work updated to changed the actual work to make it work in the source component that was failing. cc @malexanderlim

actual work updated was given by OneDesk Support team but seems like they haven't updated it yet

@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Jun 18, 2024
@vunguyenhung vunguyenhung moved this from In QA to Ready for release in Component (Source and Action) Backlog Jun 18, 2024
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/FEATURE-Refactor-OneDesk-components-to-use-latest-version-of-API-d03aed9af96e4f6191eae4eebf6b4c7f

Component (Source and Action) Backlog automation moved this from Ready for release to Done Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged For maintainers: This issue has been triaged by a Pipedream employee
Development

Successfully merging a pull request may close this issue.

4 participants