Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulpfile.js failed to load after upgrade to Visual Studio 16.5 #1098

Closed
vjacquet opened this issue Mar 28, 2020 · 3 comments
Closed

Gulpfile.js failed to load after upgrade to Visual Studio 16.5 #1098

vjacquet opened this issue Mar 28, 2020 · 3 comments
Assignees
Projects
Milestone

Comments

@vjacquet
Copy link
Contributor

The error is "ReferenceError: primordials is not defined".

The reason is that Visual studio installs node version v12.13.1 (prior version was v10.16.3), which is not compatible with gulp 3.9.

You can find more on the subject at
https://stackoverflow.com/questions/55921442/how-to-fix-referenceerror-primordials-is-not-defined-in-node/58394828

@j2ba
Copy link
Contributor

j2ba commented Mar 29, 2020

Just encountered this too. You can get tasks running by updating gulp and gulp-sass to "^4.0.2" in core\Piranha.Manager, core\Piranha.Manager.Summernote, examples\MvcWeb (if using), and examples\RazorWeb (if using).

Piranha.Manager and Piranha.Manager.Summernote's gulp.js files need a couple tweaks as well. If you are held up, you can reference the commit in my fork here j2ba@3a2b42e.

@vjacquet
Copy link
Contributor Author

Thanks, it helped a lot.
I also had to reorder the location of the external tools to get it to work https://stackoverflow.com/a/41454385

@tidyui
Copy link
Member

tidyui commented Apr 2, 2020

Anyone interested in sending a PR for this?

@tidyui tidyui added this to the Version 8.2 milestone Apr 3, 2020
@tidyui tidyui added this to To do in Version 8.2 via automation Apr 3, 2020
@tidyui tidyui moved this from To do to Done in Version 8.2 Apr 3, 2020
@tidyui tidyui closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Version 8.2
  
Done
Development

No branches or pull requests

3 participants