Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asp-append-version to script/link tags #1840

Closed
monsieurberry opened this issue Mar 24, 2022 · 1 comment
Closed

Add asp-append-version to script/link tags #1840

monsieurberry opened this issue Mar 24, 2022 · 1 comment

Comments

@monsieurberry
Copy link

Hi!

We have just successfully updated to v10 - it was a breeze so thank you.

For just one of our employees, they saw a blank screen when logging into the manager and the following message in the console...

image

After a bit of investigation I realised the piranha-deps.min.js was cached in their browser, and doing a hard refresh saved the day. This got me wondering if adding asp-append-version="true" to the manager layouts would help mitigate this kind of error in future releases?

Thanks again for all the great work
Adam

@tidyui
Copy link
Member

tidyui commented Mar 29, 2022

Given how we've embedded the resources in the manager asp-append-version doesn't seem to work, but we can append a hash of the current assembly version to the resources.

@tidyui tidyui added this to the Version 10.1 milestone Mar 29, 2022
@tidyui tidyui added this to To do in Version 10.1 via automation Mar 29, 2022
@tidyui tidyui closed this as completed in dadb218 Mar 29, 2022
Version 10.1 automation moved this from To do to Done Mar 29, 2022
@tidyui tidyui modified the milestones: Version 10.1, Version 10.0.3 Mar 31, 2022
@tidyui tidyui removed this from Done in Version 10.1 Mar 31, 2022
@tidyui tidyui self-assigned this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants