Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 API General Feedback #155

Closed
30 of 35 tasks
cloneofghosts opened this issue Feb 16, 2024 · 6 comments
Closed
30 of 35 tasks

V2 API General Feedback #155

cloneofghosts opened this issue Feb 16, 2024 · 6 comments
Assignees

Comments

@cloneofghosts
Copy link
Collaborator

cloneofghosts commented Feb 16, 2024

Describe the issue

I'm sure you already have a list of things to fix/implement on the V2 Alpha endpoint but here's a list of things that I noticed:

  • negative Longitudes displaying incorrectly (-75 shows as 285)
  • currently Block Missing
  • daily Block Missing
  • alerts Block Missing
  • Summary/Icon data points missing
  • precipType seems broken
  • hourly data points not in the same order as the live API
  • units parameter not working correctly
  • visibility is not capped
  • some data points using incorrect units for SI units (pressure, visibility, cloudCover, humidity and precipProbability)
  • cloud cover on currently data is not a percentage like hourly/daily
  • nearestStormDistance and nearestStormBearing shouldn't be on the hourly block
  • sourceTimes is a floating point number instead of an integter
  • many data points being negative when it doesn't make sense (uvIndex, nearestStormDistance, etc.)
  • moonPhase and daily precipAccumulation aren't rounded to two decimal places
  • currently, hourly and daily precipitation data points are rounded to two decimal places instead of four
  • windBearing and nearestStormBearing is not a whole number
  • precipIntensityError seems to always display 2 on the minutely block
  • time parameter on hourly block is a floating point number
  • hourly block seems to show array positioning
  • minutely block seems to show array positioning
  • minutely and currently precipitation data seems to be using GFS/GEFS in the CONUS domain
  • partly cloudy always shows night icon in currently data
  • partly cloudy always shows night icon in hourly data
  • temperature/apparent temperature/dew point cannot be below zero when they should be able to
  • pressure value seems broken on hourly data
  • most time data points are show the incorrect time on daily data points
  • temperatureLow is showing this mornings low instead of the low for tonight (could be an issue for all days but the low time is broken)
  • Precipitation Probability can go over 1
  • currently data sometimes shows a clear icon with no day/night suffix
  • currently precipType shows clear instead of none
  • daily temperatureHigh doesn't seem to work correctly. Most cases it shows a temperature lower than the temperatureMax when they should be around the same temperature

If anyone else is using the V2 Alpha API feel free to add things that you've run into. Also for things that are fixed on the V2 Alpha endpoint already do you want to close the issue or leave it open until it launches? I'm fine with leaving it open but it would clean up the issue list and the project list if marked as complete.

Acknowledgements

  • I have searched this repository and Home Assistant Repository to see if the issue has already been reported.
  • I have read through the API documentation before opening this issue.
  • I have written an informative title.
@cloneofghosts
Copy link
Collaborator Author

@alexander0042 I'm guessing this is something you're working on? Been getting a Internal Server Error message whenever I try to visit the V2 endpoint URL and the V2 dev URL still does not work.

@alexander0042
Copy link
Collaborator

You guessed right- I was pulling together a paper for a conference last month, and then away skiing (and checking the weather constantly) this week. Back at this next week, so should be able to start checking some of these off! I really appreciate you putting this list together, since I'll let me keep track of the main things ✅

@cloneofghosts
Copy link
Collaborator Author

cloneofghosts commented Mar 7, 2024

@alexander0042 The V2 Alpha API has been returning an Internal Server Error for the past day or so. Did you push up an update which broke things or did it just happen to break by itself?

EDIT: Is the model runtime section in the flags block broken or something? This is what I see:

"sourceTimes": {
"hrrr_subh": "2024-03-04 18Z",
"hrrr_0-18": "2024-03-04 16Z",
"nbm": "2024-03-03 05Z",
"hrrr_18-48": "2024-03-05 06Z",
"gfs": "2024-03-04 12Z",
"gefs": "2024-03-04 16Z"
},

HRRR 0-18 doesn't have the same time as the sub-hourly HRRR and 18-48 has a future date. NBM it says hasn't had any new data in over a day when it should be the same time as HRRR_subh

Has the NBM data stopped integrating? I thought the model ran every hour and under sourceTimes I see this "nbm": "2024-03-05 17Z",

I thought that the API would fall-back to use other sources if the one used in the forecasts hasn't been updated in x number of hours. From what I can tell the data is still somewhat accurate but the temperatures are way off.

EDIT: Seems like NBM has broken again and it looks like GFS is also broken. I'm also a bit confused as to where some of the currently data is coming from. Some of it seems to be from the hourly data but others (temperature and precipIntensity) seem to come from somewhere else. Is that data coming from a different model which would explain why the temperature seems to be pretty off when compared to the live API.

@cloneofghosts cloneofghosts pinned this issue Mar 11, 2024
@cloneofghosts
Copy link
Collaborator Author

cloneofghosts commented Mar 11, 2024

Ah you moved it to the dev endpoint so disregard my comment.

@alexander0042
Copy link
Collaborator

Yea, there was a bit of chaos there while I tried a bunch of different things. Adding NBM in turned out to be a bit more complex than I expected, since it meant that which model was being used to grab a specific variable became much more dynamic, instead of just HRRR/ GFS. But it's all in there now, and crucially, the infrastructure to actually serve data from it is now in place, which was a key step. I also ended up focusing more on response speed than I initially planned, since the times were pretty good, I wanted to see how fast I could get them (answer- real quick, at least 10x the speed of the old one, sometimes closer to 50x!)

If it makes sense to you, I'm going to start a new issue thread and pin it with some notes on version 2. I can't say enough how great your details are in this one, and I'll go through them one by one now that all the infrastructure is in place, but my ideas is adding some notes for others to a top level comment (or maybe as a discussion)?

@cloneofghosts
Copy link
Collaborator Author

Sure you can create a new issue for notes and v2 feedback. Will close this one so you can create your issue.

@cloneofghosts cloneofghosts closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
@cloneofghosts cloneofghosts unpinned this issue Mar 12, 2024
@Pirate-Weather Pirate-Weather locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Status: Done
Development

No branches or pull requests

2 participants