Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Invalid times in timemachine response #46

Closed
bakobako opened this issue Apr 6, 2023 · 2 comments
Closed

Bug: Invalid times in timemachine response #46

bakobako opened this issue Apr 6, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@bakobako
Copy link

bakobako commented Apr 6, 2023

Hey, I have been playing around with the API and i found something i think might be a bug :

When calling :

curl --location 'https://timemachine.pirateweather.net/forecast/API_TOKEN/50.0,14.43,1609452000?units=si'

I get the following daily data :

"daily": {
        "data": [
            {
                "time": 1609369200,
                "icon": "clear-day",
                "summary": "Clear",
                "sunriseTime": 1609444732,
                "sunsetTime": 1609474091,
                "moonPhase": 0.55,
                "precipAccumulation": 0.01,
                "precipType": "none",
                "temperatureHigh": 4.23,
                "temperatureHighTime": 1609419600,
                "temperatureLow": -1.96,
                "temperatureLowTime": 1609448400,
                "apparentTemperatureHigh": 2.77,
                "apparentTemperatureHighTime": 1609419600,
                "apparentTemperatureLow": -4.85,
                "apparentTemperatureLowTime": -4,
                "dewPoint": -2.43,
                "pressure": 968.97,
                "windSpeed": 1.97,
                "windBearing": 169.89,
                "cloudCover": 0.14,
                "temperatureMin": -1.96,
                "temperatureMinTime": 1609448400,
                "temperatureMax": 4.23,
                "temperatureMaxTime": 1609419600,
                "apparentTemperatureMin": -4.85,
                "apparentTemperatureMinTime": -4,
                "apparentTemperatureMax": 2.77,
                "apparentTemperatureMaxTime": 1609419600
            }
        ]
    }

The apparentTemperatureMinTime , apparentTemperatureLowTime are incorrect right? or am i misunderstanding that they should be UNIX timestamps?

@alexander0042 alexander0042 added the bug Something isn't working label Apr 7, 2023
@alexander0042 alexander0042 self-assigned this Apr 7, 2023
@alexander0042
Copy link
Collaborator

Hi,

Sorry about this- it’s 100% a bug I introduced while trying to fix something else! I’ve tagged it for fixing, and should have it corrected by early next week.

Thanks for bringing this to my attention!

@alexander0042
Copy link
Collaborator

Sorry for the radio silence here! I ended up fixing this shortly after, but completely forgot to update the issue.

Since this should be addressed, I'm going to close, but absolutely let me know if I've missed anything or if there are any other issues, and thanks again for using this service!

@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants