New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 2.9.b forgets mediainfo path value #132
Comments
The path settings has been remove and need to set separately. |
A pointer where to set would had been nice.. anyway, found the mentioning of piwigo-videojs/include/admin/admin_photo.php in https://github.com/xbgmsharp/piwigo-videojs/wiki/Using-MediaInfo%2C-ffmpeg-without-installing-it-inside-the-hosting-system but ... seriously? One has to edit the admin_photo.php file now that gets overwritten with each update? Or am I missing something? |
You might want to check #130 (comment) |
If |
I would assume so. |
I am having kind of the same issue after upgrading from 2.8.a to 2.9.b. Regarding the code, the array_merge function is often used but it seems to me that it is done the wrong way. For example, in
So if we want the database options to overwrite the default ones, we should use I switched this at line 84 of |
Upgrading from 2.9.a to 2.9.b forgot the path to mediainfo in the form
LD_LIBRARY_PATH=/somepath/lib /somepath/bin/mediainfo
and kept the entry field filled with just
mediainfo
instead, consequently the warning icon mark appeared.Entering the old value again and dry-running Synchronise, mediainfo wasn't warned about anymore and metadata was extracted. Field value was remembered then.
BUT, switching to the Configuration tab and back to the Synchronise tab the field value is lost again, leaving just
mediainfo
with a warning icon; this also happens after non-dry-run. Effectively one has to enter the correct value before each Synchronise run.Expected: old value of the path edit field is preserved during upgrade and when edited.
The text was updated successfully, but these errors were encountered: