Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDView - OpenColorIO 2 GPU support incomplete #1924

Open
remia opened this issue Jun 27, 2022 · 3 comments
Open

USDView - OpenColorIO 2 GPU support incomplete #1924

remia opened this issue Jun 27, 2022 · 3 comments

Comments

@remia
Copy link

remia commented Jun 27, 2022

It seems that the support for OCIO v2 (from b08e77f) is currently broken as it's trying to use the new GPU path (via getDefaultGPUProcessor()) but fail to then setup all the resources required (there is now an arbitrary number of 1D and 3DLUTs to query). While in may work on LUTs free config like the newer ACES configs, it will break on other configs. This was also discussed in #1386 I believe.

A quick fix could be to use the Legacy GPU Processor in v2.0.1, then potentially migrate to a v2 compliant GPU path, an example being available in Python here.

@remia remia changed the title OpenColorIO 2 GPU support incomplete USDView - OpenColorIO 2 GPU support incomplete Jun 27, 2022
@sunyab
Copy link
Contributor

sunyab commented Jun 30, 2022

Filed as internal issue #USD-7460

@spiffmon
Copy link
Member

spiffmon commented Jul 2, 2022

Thanks for filing, @remia . Pixar has not yet transitioned to 2.x, and we accepted the referenced PR with the understanding that we couldn't yet really validate or support it. We would consider a further PR that completes the work, though!

@creijon
Copy link
Contributor

creijon commented Jul 7, 2022

I've put a PR with OCIO 2.1.1 GPU support for Metal and OpenGL here: #1936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants