Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_usd.py: potential file name collisions #457

Open
jcowles opened this issue Apr 10, 2018 · 2 comments
Open

build_usd.py: potential file name collisions #457

jcowles opened this issue Apr 10, 2018 · 2 comments

Comments

@jcowles
Copy link

jcowles commented Apr 10, 2018

Description of Issue

build_usd.py downloads several zip files, many of which are not prefixed with a library name. Here is a sample of what my $build/src directory contains:

1.5.1.zip
1.7.1.zip
v2.2.0.zip
v3_1_1.zip

These file names may one day collide, but more immediately, it makes it harder to determine which library each file contains.

System Information (OS, Hardware)

Windows

Package Versions

USD v0.8.4

@jtran56
Copy link

jtran56 commented Apr 10, 2018

Filed as internal issue #159450.

@Cewein
Copy link

Cewein commented Apr 29, 2024

The possible collision is still here with

filename = url.split("/")[-1]

I'll will look into it. For gitlab and github url it should be ok.

For example this could work :

url.split("/")[4] + "-" + url.split("/")[-1]

it would give for this type of url : https://github.com/oneapi-src/oneTBB/archive/refs/tags/v2020.3.zip
This result : oneTBB-v2020.3.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants