[hio] Don't export stbimage functions for linkage with things that may also use stbimage. #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y also use stbimage.
|
Filed as internal issue #USD-6662 |
|
Hi @marsupial, this change caused one of our internal test builds on Linux in strict mode to fail. This was because gcc was emitting a bunch of "unused function" warnings now that the stb_* functions are marked static. I ended up adding a new pragma to arch/pragmas.h so that we could suppress those warnings in this file and get things working again. Let me know if you feel we should solve this another way, otherwise this should land shortly. Thanks! |
|
If I understand, you'll keep whats in this MR, but just surround it in a new |
pixar-oss
pushed a commit
that referenced
this pull request
Apr 27, 2021
function warnings See #1498 (Internal change: 2161720)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Add pre-processor macros so stbimage functions aren't exported.
Fixes Issue(s)
When building/linking with other things that use stbimage, symbols can be defined multiple times.