Skip to content
This repository has been archived by the owner on May 21, 2022. It is now read-only.

Final access token refresh fix + error handling fixes #39

Merged
merged 4 commits into from Apr 3, 2022

Conversation

nuc1e4r5n4k3
Copy link
Contributor

This fixes a bunch is small but critical issues:

  1. Stupid autocomplete mistake that causes all these 'Ratelimited' errors.
  2. Properly log error data whenever place() fails (unfortunately reddit API responses are not exactly consistent...)

And most important:

  1. Make sure the access token refresh actually affects attemptPlace(). Right now the refreshed tokens are effectively silently discarded, causing issues after 1 hour of uptime.

@NoahvdAa
Copy link
Member

NoahvdAa commented Apr 3, 2022

Could you bump the bot version?

@nuc1e4r5n4k3
Copy link
Contributor Author

Done

Copy link
Member

@NoahvdAa NoahvdAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from web

@NoahvdAa NoahvdAa merged commit f7b73f6 into PlaceNL2022:master Apr 3, 2022
anoadragon453 pushed a commit to anoadragon453/Bot that referenced this pull request Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants