Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with system wlroots 0.15.0 #316

Closed
jbeich opened this issue Nov 26, 2021 · 4 comments
Closed

Fails to build with system wlroots 0.15.0 #316

jbeich opened this issue Nov 26, 2021 · 4 comments

Comments

@jbeich
Copy link

jbeich commented Nov 26, 2021

Regressed by wlroots@1d3dd7f

$ meson setup --force-fallback-for=libliftoff /tmp/gamescope_build
$ meson compile -C /tmp/gamescope_build
[...]
src/wlserver.cpp:26:10: fatal error: 'wlr/backend/noop.h' file not found
#include <wlr/backend/noop.h>
         ^~~~~~~~~~~~~~~~~~~~

See also:

@jbeich jbeich changed the title Fails to build with wlroots 0.15.0 (2021-11-25 snapshot) Fails to build with system wlroots 0.15.0 (2021-11-25 snapshot) Nov 26, 2021
@emersion
Copy link
Collaborator

That's expected, only the subproject git submodule is supported. I'll bump it once wlroots 0.15.0 is released, but we might need some unreleased wlroots changes again at some point, and then 0.15.0 would stop working.

@jbeich jbeich changed the title Fails to build with system wlroots 0.15.0 (2021-11-25 snapshot) Fails to build with system wlroots 0.15.0 Dec 19, 2021
@emersion
Copy link
Collaborator

Done in 11f89c1.

@jbeich
Copy link
Author

jbeich commented Dec 20, 2021

Still fails here:

src/wlserver.cpp:26:10: fatal error: 'wlr/backend/noop.h' file not found
#include <wlr/backend/noop.h>
         ^~~~~~~~~~~~~~~~~~~~

According to CI logs noop.h likely comes from system wlroots-0.14.1-2 package:
https://github.com/Plagman/gamescope/blob/11f89c1b15eb8cf30cacfef42b092ef11808babb/.github/workflows/main.yml#L17

@emersion
Copy link
Collaborator

Right, we install wlroots system-wide as a cheap way to bring all of its deps. Maybe we should explicitly install the deps instead.

Anyway, fixed in c1958be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants