Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.11.11 fails to build on 32-bit systems #410

Closed
jbeich opened this issue Feb 12, 2022 · 1 comment
Closed

3.11.11 fails to build on 32-bit systems #410

jbeich opened this issue Feb 12, 2022 · 1 comment

Comments

@jbeich
Copy link

jbeich commented Feb 12, 2022

Regressed by f156763. From error log:

src/vblankmanager.cpp:285:18: error: no matching function for call to 'max'
                                sleepyTime = std::max( sleepyTime, 0l );
                                             ^~~~~~~~
/usr/include/c++/v1/algorithm:2633:1: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('long long' vs. 'long')
max(const _Tp& __a, const _Tp& __b)
^
/usr/include/c++/v1/algorithm:2644:1: note: candidate template ignored: could not match 'initializer_list<type-parameter-0-0>' against 'long long'
max(initializer_list<_Tp> __t, _Compare __comp)
^
/usr/include/c++/v1/algorithm:2653:1: note: candidate function template not viable: requires single argument '__t', but 2 arguments were provided
max(initializer_list<_Tp> __t)
^
/usr/include/c++/v1/algorithm:2624:1: note: candidate function template not viable: requires 3 arguments, but 2 were provided
max(const _Tp& __a, const _Tp& __b, _Compare __comp)
^

Replacing 0l with 0ll helps but breaks 64-bit systems instead. Maybe it should use std::max<int64_t>(...), static_cast<int64_t>(0) or similar where int64_t can probably be replaced by decltype(sleepyTime).

@jbeich
Copy link
Author

jbeich commented Feb 13, 2022

Fixed by 1594e02.

@jbeich jbeich closed this as completed Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant