Unbreak build on FreeBSD #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've removed |
|
Did you have the chance to test if gamescope was working fine on FreeBSD with this PR? |
|
|
OK, thanks for the status update! |
|
FreeBSD recently stubbed |
On BSD systems only the super-user may lower priority values.
meson.build:40:0: ERROR: Dependency "libcap" not found, tried pkgconfig and cmake
src/main.cpp:7:10: fatal error: 'sys/capability.h' file not found
#include <sys/capability.h>
^~~~~~~~~~~~~~~~~~
src/main.cpp:244:2: error: unknown type name 'cap_t'
cap_t caps = cap_get_proc();
^
src/main.cpp:244:15: error: use of undeclared identifier 'cap_get_proc'
cap_t caps = cap_get_proc();
^
src/main.cpp:247:3: error: unknown type name 'cap_flag_value_t'
cap_flag_value_t nicecapvalue = CAP_CLEAR;
^
src/main.cpp:247:35: error: use of undeclared identifier 'CAP_CLEAR'
cap_flag_value_t nicecapvalue = CAP_CLEAR;
^
src/main.cpp:248:23: error: use of undeclared identifier 'CAP_SYS_NICE'
cap_get_flag( caps, CAP_SYS_NICE, CAP_EFFECTIVE, &nicecapvalue );
^
src/main.cpp:248:37: error: use of undeclared identifier 'CAP_EFFECTIVE'
cap_get_flag( caps, CAP_SYS_NICE, CAP_EFFECTIVE, &nicecapvalue );
^
src/main.cpp:250:24: error: use of undeclared identifier 'CAP_SET'
if ( nicecapvalue == CAP_SET )
^
DragonFly and FreeBSD adopted a similar API to Linux. Other sytems
maybe interested as well, so add a warning.
src/steamcompmgr.cpp:51:10: fatal error: 'sys/prctl.h' file not found
#include <sys/prctl.h>
^~~~~~~~~~~~~
src/steamcompmgr.cpp:3118:9: error: use of undeclared identifier 'PR_SET_CHILD_SUBREAPER'
prctl( PR_SET_CHILD_SUBREAPER, 1, 0, 0, 0 );
^
|
Is this ready? |
|
Yes apart from
|
|
You can feel free to make the SDL window init stuff a condition variable instead. The muted abuse was just convenient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime is still broken: need to file bugs as those are non-trivial.
Depends on emersion/libliftoff#52