Use DRM_CAP_CURSOR_{WIDTH,HEIGTH} for cursor buffer #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allocating the buffer with |
emersion
force-pushed
the
cursor-plane
branch
from
b0bb738
to
28f9d16
Compare
|
This is now working properly on Linux 5.9.10. This is ready for review. |
Hardware often has cursor plane limitations for the buffer size. Co-authored-by: Simon Ser <contact@emersion.fr>
The cursor plane needs to be linear on amdgpu.
emersion
force-pushed
the
cursor-plane
branch
from
28f9d16
to
28ac932
Compare
|
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7898 is now merged and CC'ed to mesa-stable, so this PR should now work on kernel+mesa latest commit too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so the buffer for the cursor can pass amdgpu's size checks.
Tested with:
(-w and -h are necessary to remove any scaling because the cursor plane can't be used together with primary plane scaling.)
Then check that the cursor plane is used with
drm_info.This is not ready to be merged because amdgpu prints some errors, oops and the cursor isn't displayed properly. https://gitlab.freedesktop.org/drm/amd/-/issues/1390