Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain me value through error flow #49

Closed
fluffy-critter opened this issue Nov 4, 2019 · 1 comment · Fixed by #52
Closed

Retain me value through error flow #49

fluffy-critter opened this issue Nov 4, 2019 · 1 comment · Fixed by #52
Labels
enhancement New feature or request flask Functionality relating to the built-in Flask wrapper UX Relating to the end-user experience

Comments

@fluffy-critter
Copy link
Contributor

If there's an error logging in, the disposition.Error should carry the failed identity URL so that the login form can present it as a default value.

Also, on the Flask handler, the error disposition could be passed through to the template, instead of using the message flashing mechanism which is a bit unwieldy.

@fluffy-critter fluffy-critter added enhancement New feature or request flask Functionality relating to the built-in Flask wrapper UX Relating to the end-user experience labels Nov 4, 2019
@fluffy-critter fluffy-critter added wontfix This will not be worked on and removed wontfix This will not be worked on labels Dec 4, 2019
@fluffy-critter
Copy link
Contributor Author

Unfortunately this isn't possible to stash into the Disposition, as most handlers only actually have the identity URL if login has either succeeded (in which case there's no point in floating up an error) or has failed detection (in which case the handler wouldn't have been selected to begin with). The only exceptions are silo providers like Twitter and Facebook and those are kind of anathema to the point as well.

However, in the case of Flask it could be stashed into the session, and the Flask handler should use the error disposition instead of message flashing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flask Functionality relating to the built-in Flask wrapper UX Relating to the end-user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant