Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception handler should check for path aliases #240

Closed
fluffy-critter opened this issue Jul 10, 2019 · 0 comments · Fixed by #409 or #410
Closed

Exception handler should check for path aliases #240

fluffy-critter opened this issue Jul 10, 2019 · 0 comments · Fixed by #409 or #410
Labels
bug Something isn't working code quality Places where the code quality or readability can be improved
Milestone
0.7

Comments

@fluffy-critter
Copy link
Collaborator

fluffy-critter commented Jul 10, 2019 •
edited

Expected Behavior

Not every path is covered by a routing rule anymore. Also a lot of the path alias checking could be handled more centrally. So a lot of these things should be handled in the exception handler instead.

Current Behavior

If there's a path alias that includes a leading /_ it will likely not be triggered.

Possible Solution

Steps to Reproduce (for bugs)

Context
@fluffy-critter fluffy-critter added the code quality Places where the code quality or readability can be improved label Jul 10, 2019
@fluffy-critter fluffy-critter added this to the 0.6 milestone Jul 15, 2019
@fluffy-critter fluffy-critter added the bug Something isn't working label Jul 15, 2019
@fluffy-critter fluffy-critter modified the milestones: 0.6, 0.7 Jan 4, 2020
@fluffy-critter fluffy-critter mentioned this issue Aug 4, 2020
Merged
@fluffy-critter fluffy-critter mentioned this issue Aug 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working code quality Places where the code quality or readability can be improved
Projects
None yet
Milestone
0.7
1 participant
@fluffy-critter