Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token endpoint doesn't support AutoAuth #304

Closed
fluffy-critter opened this issue Oct 30, 2019 · 3 comments · Fixed by #383
Closed

Token endpoint doesn't support AutoAuth #304

fluffy-critter opened this issue Oct 30, 2019 · 3 comments · Fixed by #383
Labels
auth Issues pertaining to authenticated access to private content
Projects
Milestone

Comments

@fluffy-critter
Copy link
Collaborator

fluffy-critter commented Oct 30, 2019

Current issues:

  1. Needs to send root_uri, realm, and callback_uri on the code verification
  2. In an AutoAuth verification response, it's just the status code that matters (no JSON response?) and so the values are filled in from the request, not the response
@fluffy-critter fluffy-critter added the auth Issues pertaining to authenticated access to private content label Oct 30, 2019
@fluffy-critter fluffy-critter added this to To do in AutoAuth Nov 5, 2019
@fluffy-critter fluffy-critter added this to the 0.6 milestone Jan 4, 2020
@fluffy-critter fluffy-critter modified the milestones: 0.6, 0.7 Feb 5, 2020
@fluffy-critter
Copy link
Collaborator Author

I am told that once again I have misunderstood something in the spec. What's supposed to happen is if callback_url is set, the Publ endpoint responds 202 with no body, and then makes the call to callback_url itself. Sheesh.

@fluffy-critter
Copy link
Collaborator Author

There's a better description of the actual steps taken by the token endpoint at https://www.svenknebel.de/temp/autoauth.html (via sknebel/AutoAuth#19). It looks like if the token endpoint gets a payload with callback_url then it needs to queue that stuff up. Which means, in Publ, that token stuff needs a worker threadpool, and the callback stuff should be parsed out. This also means that for callback_url everything can go in the background, unlike redirect_uri which has a synchronous response, so some refactoring is in order.

@fluffy-critter
Copy link
Collaborator Author

AutoAuth is dead, long live TicketAuth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Issues pertaining to authenticated access to private content
Projects
No open projects
AutoAuth
  
To do
Development

Successfully merging a pull request may close this issue.

1 participant