Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change __getattr__ ad-hoc binding to @property where applicable #51

Closed
fluffy-critter opened this issue Apr 17, 2018 · 0 comments
Closed

Change __getattr__ ad-hoc binding to @property where applicable #51

fluffy-critter opened this issue Apr 17, 2018 · 0 comments
Labels
code quality Places where the code quality or readability can be improved

Comments

@fluffy-critter
Copy link
Collaborator

fluffy-critter commented Apr 17, 2018 •
edited

Rationale

Ad-hoc __getattr__ for populating properties both makes PyLint unhappy and is difficult to properly document. It'd be a good idea to switch to @cached_property, which exists for a reason.
@fluffy-critter fluffy-critter added the code quality Places where the code quality or readability can be improved label Apr 17, 2018
@fluffy-critter fluffy-critter mentioned this issue Apr 25, 2018
Open
@fluffy-critter fluffy-critter changed the title Change __getattr__ add-hoc binding to @property where applicable Change __getattr__ ad-hoc binding to @property where applicable Apr 26, 2018
This was referenced May 10, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Places where the code quality or readability can be improved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fluffy-critter