-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definition of true leaf, expending leaf, mature leaf #37
Comments
The issue here is not the presence or absence of a true leaf, but rather its stage. A true leaf is present whenever there is a vascular leaf that is not a cotyledon, regardless of the stage it is in. The problem is that we map NPN "leaves present" to the presence of a true leaf, when in fact we need to map it to the presence of a true leaf in the post-expansion (mature) stage. I would recommend making the trait and stage definitions more specific, rather than changing the definition of true leaf. Suggested changes to follow. |
The other issue here is that NPN separates leaves into "young leaves" and "leaves", rather than "expanding leaves" and "mature leaves", as the PO does. NPN definitions: young leaf (forb): A leaf is considered "young" before it has reached full size or turned the darker green color or tougher texture of mature leaves on the plant. Do not include fully dried or dead leaves. It is accurate to say that all young leaves (sensu NPN) are expanding leaves (sensu PO), but one cannot say that all "leaves" (sensu NPN) are post-expansion leaves (sensu PO) because post-expansion leaves includes leaves that are fully expanded but not yet fully mature. I think the best way to address this is to make a new class for mature leaf stage, which will be a subclass of post-expansion stage. We can request that PO pick it up. I'll have to do a little research into how to define accurately mature, but we can get the term up there for now so we can proceed. |
For completeness, we would need to also define a class for those leaves that are fully expanded but not yet fully mature. |
Good solution. Is Ellen subscribed to the github repo so she can follow?
…On Thu, Jun 15, 2017 at 8:17 PM, Ramona Walls ***@***.***> wrote:
The other issue here is that NPN separates leaves into "young leaves" and
"leaves", rather than "expanding leaves" and "mature leaves", as the PO
does.
NPN definitions:
young leaf (tree/shrub): A leaf is considered "young" and "unfolded" once
its entire length has emerged from a breaking bud, stem node or growing
stem tip, so that the leaf stalk (petiole) or leaf base is visible at its
point of attachment to the stem, but before the leaf has reached full size
or turned the darker green color or tougher texture of mature leaves on the
plant.
young leaf (forb): A leaf is considered "young" before it has reached full
size or turned the darker green color or tougher texture of mature leaves
on the plant. Do not include fully dried or dead leaves.
It is accurate to say that all young leaves (sensu NPN) are expanding
leaves (sensu PO), but one cannot say that all "leaves" (sensu NPN) are
post-expansion leaves (sensu PO) because post-expansion leaves includes
leaves that are fully expanded but not yet fully mature.
I think the best way to address this is to make a new class for mature
leaf stage, which will be a subclass of post-expansion stage. We can
request that PO pick it up. I'll have to do a little research into how to
define accurately mature, but we can get the term up there for now so we
can proceed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAcc7LFDOwJOR0U4DY8xJPtJupUN0XT7ks5sEcmxgaJpZM4N725g>
.
|
Not yet, but I have asked her to get an account so I can tag her. |
So the problem I was bringing up was not about expanding vs. mature, but rather "unfolding" vs. "unfolded". As such, this might be your use case for issue#40. "Leaves" includes leaves that are unfolded, expanding, post-expansion and mature, but does NOT include that stage while the first true leaf from the bud is in the process of "unfolding". "Young leaves" includes leaves that are unfolded and expanding, but not mature, and as with "Leaves", not that stage while the first true leaf from the bud is in the process of "unfolding". Thus this phase overlaps with "Leaves" until all leaves on the plant are in post-expansion. (BTW, we only use this phase for evergreen and drought-deciduous plants which might have leaves on the tree all year long, so as to distinguish the period of active leaf growth.) There is that situation we discussed earlier for drought-decid plants were expansion is completed but maturing is not, which maybe is what you were getting at here. It's ok with me if we overlook that distinction and just map "Young leaves" to leaves before the post-expansion stage. |
@edenny, you are right that your comment I copied into the first comment above deals with unfolding versus unfolded leaves. However, if I understood the situation correctly, there was also an issue with young leaves. NPN young leaves includes both expanding leaves and fully expanded leaves that have not yet developed the color or toughness of mature leaves. For this reason, in order to accurately define young leaves, we need to distinguish between expanded but not mature leaves versus mature leaves. |
Yes, fine with me if we want to formalize that distinction! |
New classes to create: vascular leaf mature stage: A {vascular leaf post-expansion stage} that begins when the {vascular leaf} has turned the darker green color or tougher texture of mature leaves and ends with the onset of the {vascular leaf senescence stage}. traits: mature leaf presence (revise current def): A 'plant phenological trait' (PPO:0002001) that is measured by the number of true leaves (PPO:0000209) on a 'whole plant' (PO:0000003) that are in the {vascular leaf mature stage}. plus corresponding present and absent classes |
Once all the traits are in place, will need update the phenological stages: mature leaf phenological stage (update current def): A {non-senescing leaf phenological stage} in which some participant plant has at least one {vascular leaf} in the {vascular leaf mature stage}. young leaf phenological stage (new term): A {non-senescing leaf phenological stage} in which some participant plant has at least one {vascular leaf} in the {vascular leaf expansion stage} or {vascular leaf expanded not mature stage}. plus corresponding logical definitions. |
All that is left to do is to remake the ontology, but first I have to switch back to java 8. Will do that after dinner then close this issue. |
We still need classes that map to NPN:leaves, which includes PPO:young leaves and PPO:mature leaves, but not unfolding leaves. I also realize that it is not enough to have a class for "young leaf phenological stage. We score the data by traits and then make inferences about stages, so we need to specifically have a trait for young leaf presence, and then define the stage based on that, at least for the NPN mappings. Will add the following classes: unfolded leaf presence: A {plant phenological trait} that is measured by the number of true leaves {$true leaf} on a {whole plant} that are in the {vascular leaf unfolded expanding stage} or {vascular leaf post-expansion stage}. unfolded leaf phenological stage: A {non-senescing leaf phenological stage} in which some participant plant has at least one {vascular leaf} in the {vascular leaf unfolded expanding stage} or {vascular leaf post-expansion stage}. |
On that last definition for the {unfolded leaf phenological stage} not sure it will work for NPN because we include senescing leaves also in our "Leaves" phenophase. Do we need to specify it as a non-senescing leaf stage as opposed to either senescing or non-senescing? |
Or can we create yet another class that includes senescing and non-senescing? |
Based on @edenny 's last comment, we should change the definitions of the unfolded leaf terms to include senescing leaves: unfolded leaf presence: A {plant phenological trait} that is measured by the number of true leaves {$true leaf} on a {whole plant} that are in the {vascular leaf unfolded expanding stage}, {vascular leaf post-expansion stage}, or {vascular leaf senescent stage}. unfolded leaf phenological stage: A {non-senescing leaf phenological stage} in which some participant plant has at least one {vascular leaf} in the {vascular leaf unfolded expanding stage}, {vascular leaf post-expansion stage}, or {vascular leaf senescent stage}. These changes will also affect issue #40. |
That last definition doesn't work because the class now includes senescing leaves, so it can no longer be a subclass of 'non-senescing leaf phenological stage'. Should this be a subclass of 'vascular leaf phenological stage'? |
Yes, that was an oversight. Unfolded leaf phenological stage should indeed be a subclass of vascular leaf phenological stage. |
From Ellen:
Almost all of the presence and absence class definitions for vegetative stages include mention of a {true leaf} which is defined as a vascular leaf that is not a cotyledon. We need to modify this somehow, either by changing the definition of {true leaf}, or by adding an additional word/phrase in the present/absent class definitions to indicate that this leaf is not just a non-cotyledon vascular leaf, but also "unfolded" in the sense that the whole length of the leaf is visible, not just the tip. This holds for NPN as well as BBCH (10-19) phenophases (right, Kjell?). I think the only difference is that NPN indicates visibility of the petiole while BBCH does not, and I am fine with glossing over the petiole issue and just indicating that the whole leaf blade or the whole length of the leaf (or whatever wording seems appropriate) has become visible.
The text was updated successfully, but these errors were encountered: