New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astar crowdloan support #502
Conversation
acde834
to
328d2af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments but none are related to required functionality. We can sort them out in follow-up PRs.
Great work! 💪
@@ -333,7 +401,20 @@ pub fn run() -> Result<()> { | |||
} | |||
Some(Subcommand::Revert(cmd)) => { | |||
let runner = cli.create_runner(cmd)?; | |||
if runner.config().chain_spec.is_shiden() { | |||
if runner.config().chain_spec.is_astar() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is repeated a lot...perhaps we can look into a helper method or macro in the future.
@@ -0,0 +1,76 @@ | |||
//! The Shiden Network EVM precompiles. This can be compiled with ``#[no_std]`, ready for Wasm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Astar Network?
if batches.is_empty() { return Err("Benchmark not found for this pallet.".into()) } | ||
Ok(batches) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try-runtime should also be here and in command.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good
Pull Request Summary
This is Astar Crowdloan preparation PR. It consist of Astar runtime and client side support code, including chain spec and launch extentions.
Check list
This pull request makes the following changes:
Adds
Fixes
Changes
To-dos