Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astar crowdloan support #502

Merged
merged 6 commits into from Nov 5, 2021
Merged

Astar crowdloan support #502

merged 6 commits into from Nov 5, 2021

Conversation

akru
Copy link
Member

@akru akru commented Nov 2, 2021

Pull Request Summary

This is Astar Crowdloan preparation PR. It consist of Astar runtime and client side support code, including chain spec and launch extentions.

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • updated spec version
  • relies on other tasks
  • documentation changes
  • tests and/or benchmarks are included
  • changed API client type definition or chain metadata

This pull request makes the following changes:

Adds

  • (ex: Add feature A)

Fixes

  • (ex: Fix validation function)

Changes

  • (ex: Change document B)

To-dos

*Feel free to remove this section if it's not applicable

  • (ex: add user list)

@akru akru marked this pull request as ready for review November 5, 2021 08:21
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but none are related to required functionality. We can sort them out in follow-up PRs.

Great work! 💪

@@ -333,7 +401,20 @@ pub fn run() -> Result<()> {
}
Some(Subcommand::Revert(cmd)) => {
let runner = cli.create_runner(cmd)?;
if runner.config().chain_spec.is_shiden() {
if runner.config().chain_spec.is_astar() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is repeated a lot...perhaps we can look into a helper method or macro in the future.

@@ -0,0 +1,76 @@
//! The Shiden Network EVM precompiles. This can be compiled with ``#[no_std]`, ready for Wasm.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astar Network?

if batches.is_empty() { return Err("Benchmark not found for this pallet.".into()) }
Ok(batches)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try-runtime should also be here and in command.rs

Copy link
Contributor

@hoonsubin hoonsubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

@akru akru merged commit 8cf7f98 into development/shiden Nov 5, 2021
@akru akru deleted the feature/astar-runtime branch November 5, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants