Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need a import plasmapy GitHub Action check? #1447

Closed
rocco8773 opened this issue Feb 26, 2022 · 3 comments
Closed

Do we need a import plasmapy GitHub Action check? #1447

rocco8773 opened this issue Feb 26, 2022 · 3 comments
Labels
CI Related to continuous integration GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory)

Comments

@rocco8773
Copy link
Member

I'm a little puzzled how all the checks for PR #1444 passed when an ImportError was raised when importing plasmapy.formulary.parameters (see PR #1446). I'm thinking we should add to our CI checks a check on importing plasmapy to ensure it imports without error.

@namurphy @StanczakDominik Thoughts?

@rocco8773 rocco8773 added the CI Related to continuous integration label Feb 26, 2022
@namurphy
Copy link
Member

I like it. Given my history of directly inspiring the Astropy 4.3.1 bugfix release due to accidentally deleting the astropy.units.imperial import in __init__.py, I'd say this check (and perhaps even checks that our subpackages are in the top-level namespace) would be worth having. With that said, I've probably learned my lesson. Probably.

@namurphy
Copy link
Member

namurphy commented Mar 8, 2022

I'm wondering if there's a pytest extension for this, and an existing GitHub Action...

@namurphy
Copy link
Member

Closed by #1501.

@namurphy namurphy added the GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Related to continuous integration GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory)
Projects
None yet
Development

No branches or pull requests

2 participants