Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up setuptools_scm in pyproject.toml rather than setup.py #1618

Closed
namurphy opened this issue Jul 3, 2022 · 2 comments
Closed

Set up setuptools_scm in pyproject.toml rather than setup.py #1618

namurphy opened this issue Jul 3, 2022 · 2 comments
Labels
packaging Related to packaging or distribution

Comments

@namurphy
Copy link
Member

namurphy commented Jul 3, 2022

The use of setuptools_scm in setup.py has been deprecated, and now the recommended way is to use pyproject.toml.
@rocco8773
Copy link
Member

It is already setup in our pyproject.toml, but without the [toml] option.

@namurphy
Copy link
Member Author

namurphy commented Jul 4, 2022

By gum, you're right! I got confused by the use_scm_version keyword in setup in setup.py.

@namurphy namurphy closed this as completed Jul 4, 2022
@namurphy namurphy added the packaging Related to packaging or distribution label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
packaging Related to packaging or distribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@namurphy @rocco8773